config cli and docs: make it easier for users to find the config file #2907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilyagr
force-pushed
the
config
branch
2 times, most recently
from
6c0d71e to
d996ce5
Compare
ilyagr
commented
Feb 1, 2024
ilyagr
commented
Feb 1, 2024
ilyagr
commented
Feb 1, 2024
ilyagr
force-pushed
the
config
branch
2 times, most recently
from
40007de to
2a2aa38
Compare
PhilipMetzger
approved these changes
Feb 1, 2024
yuja
reviewed
Feb 2, 2024
ilyagr
force-pushed
the
config
branch
2 times, most recently
from
79aec42 to
926e23d
Compare
martinvonz
approved these changes
Feb 2, 2024
This changes the intro section to recommend using `jj config edit` to edit the config instead of looking for the files manually.
|
I think this is good to go; I'll merge it in a bit unless I hear otherwise. Thank you everybody for the suggestions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of
jj config path, I considered suggestingbut Windows. Also, I'm not sure whether that trick would please or annoy people.
Checklist
If applicable:
CHANGELOG.md